Page 1 of 1

Patch 10.4.3

Posted: Thu Mar 09, 2017 7:29 pm
by Pathos
Thank you for the "dump_binds" enhancement. To explain for the rest:
Now, you can use "dump_binds" command to show one key (replacing the shortly lived "bind_print" command) by adding the key you want to see as an argument. It only accepts one argument. For example:

Code: Select all

> dump_binds a
[binds]: a (97) = +left
It shows that I have the key "a" bound to +left.

Anyways, I have some questions.

What does "C&P" mean here?
https://github.com/ddnet/ddnet/commit/6 ... d51bb46ad0

Can't a server fake that it's an official DDNet server even though it's not the official DDNet server?
https://github.com/ddnet/ddnet/commit/c ... c9f2e8d056
https://github.com/ddnet/ddnet/commit/5 ... 20e2381cec

What's KeySlot?
https://github.com/ddnet/ddnet/commit/b ... 2ed49ad78d

JS coder detected by Heinrich :D
https://github.com/ddnet/ddnet/commit/7 ... e03b8f31c3

Nice, big patch. It's great to see it frequently these days.

Re: Patch 10.4.3

Posted: Fri Mar 10, 2017 12:44 am
by heinrich5991
If you don't know what an abbreviation means, just enter it into (the English) Wikipedia. In this case it works, if it doesn't, try urbandictionary.com.

You can have username and password login on non-official DDNet servers.

Keys are maintained in an array, key slot is just the index in that array, nothing you need to be concerned about when just using the feature.

Just a different indent style. TW uses the Allman style (didn't really know this name before this post) and there are a few others. See Wikipedia: https://en.wikipedia.org/wiki/Indent_style#Allman_style.

Re: Patch 10.4.3

Posted: Fri Mar 10, 2017 5:40 am
by Learath2
C&P Is "copy and paste" basically while recoding the auth system I forgot that I wasn't using pointers anymore but indexes to an array, which answers your third question. A KeySlot is an index to a key in the key array.

Re: Patch 10.4.3

Posted: Sat Mar 11, 2017 12:26 am
by Pathos
heinrich5991 wrote:You can have username and password login on non-official DDNet servers.
I understand this. My questions was more on whether it was exploitable or not, though exploit might be too strong of a word. How could it know for sure that it's a legitimate, official DDNet client-server connection? Is there a system already in place to amend this?

Re: Patch 10.4.3

Posted: Sat Mar 11, 2017 12:49 am
by heinrich5991
By connecting through the DDNet tab. No protection mechanism is applied here.